SF2M Rewrite (1.8.0)#109
Open
Mentrillum wants to merge 86 commits into
Open
Conversation
* Logo replaced * Add Korean Translation * Change some occurrences --------- Co-authored-by: Mentrillum <42941613+Mentrillum@users.noreply.github.com>
Fixes "Invalid parameter number: 3" error.
* Translation Update Renevant * Update renevant.sp
* fix static shake implementation fixes a stupid typo that broke the static shake. this took so long to track down since it was easy to miss and it didn't produce any errors. * Update profiles_boss_functions.sp
* fix deathcams from static this makes it so that bosses with non-public deathcams still play their deathcam when killing you with static. * I almost missed this * I have no idea how I missed this as well, wtf * dammit * I accidentally made this an array, whoops
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Over the years Slender Fortress evolved and the younger Modified counterpart also evolved, but most of the code was touched in not so good ways and sub plugins are forced to be designed around this forced nature. The main purpose of this PR is to fully modularize SF2M's codebase. Features like the flashlight, ultravision, proxy system, and music system are now properly divided up into their own files rather than have each main file rely on parts of one system that is completely unrelated to it. To accomplish this SF2M now uses private forwards, which is the local equivalent to global forwards, these can be called and other files with static functions can fire once these forwards are called.
Along with the backend changes, there will be many changes that are QoL improvements for server owners or creators, there may not be as many player QoL changes except for bug fixes. Once everything is ready to go, the final update will ship.
If there is ANY bug you've seen and figured out how to trigger, submit it as a Github issue and add the label 1.8.0. Link is here https://github.com/Mentrillum/Slender-Fortress-Modified-Versions/issues
Goals
Changes
Known bugs